----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45342/#review125768 -----------------------------------------------------------
Let's change the UNREACHABLE to an error+unauthorized. src/authorizer/local/authorizer.cpp (line 205) <https://reviews.apache.org/r/45342/#comment188623> On second thought, this case is NOT unreachable, and we should error and fail the request rather than aborting the process. - Adam B On March 25, 2016, 1:13 p.m., Yong Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45342/ > ----------------------------------------------------------- > > (Updated March 25, 2016, 1:13 p.m.) > > > Review request for mesos, Adam B, Anand Mazumdar, and Vinod Kone. > > > Bugs: MESOS-5031 > https://issues.apache.org/jira/browse/MESOS-5031 > > > Repository: mesos > > > Description > ------- > > This fix tries to make the Action enum in Authorization optional > to support upgrades. See MESOS-4997 for details. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.proto > 944a493e0979c7ffbd99f3a67785a10425fd9040 > src/authorizer/local/authorizer.cpp > 0f0d9276337858984f0b19a82ffca74ee84dc650 > > Diff: https://reviews.apache.org/r/45342/diff/ > > > Testing > ------- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
