----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45604/#review129187 -----------------------------------------------------------
src/examples/balloon_framework.cpp (lines 63 - 64) <https://reviews.apache.org/r/45604/#comment192641> Kill these two lines. src/examples/balloon_framework.cpp (lines 67 - 69) <https://reviews.apache.org/r/45604/#comment192642> Just change the type of task_memory_usage_limit from Option<Bytes> to Bytes; no need for this validation then. src/examples/balloon_framework.cpp (lines 85 - 91) <https://reviews.apache.org/r/45604/#comment192640> Ditto. Change `task_memory` to Bytes instead of Option<Bytes>. src/examples/balloon_framework.cpp (line 115) <https://reviews.apache.org/r/45604/#comment192643> s/should persist and// src/examples/balloon_framework.cpp (lines 117 - 118) <https://reviews.apache.org/r/45604/#comment192644> why would they be incomplete? - Vinod Kone On April 14, 2016, 9:43 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45604/ > ----------------------------------------------------------- > > (Updated April 14, 2016, 9:43 p.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and > Vinod Kone. > > > Bugs: MESOS-5174 > https://issues.apache.org/jira/browse/MESOS-5174 > > > Repository: mesos > > > Description > ------- > > This gives the example `balloon-framework` enough options to run > outside of the build environment. > > This also updates: > > * The style of the framework code. > * Adds an option for restricting the number of resources per task > (otherwise, it will eat up an entire node). > * Adds an option for persisting the framework and launching one task > after another. > * Adds filters for declined offers. > * Refines the shutdown logic for the executor. In particular, ironed > out bugs when the balloon executor does not exceed the memory limit. > > > Diffs > ----- > > src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a > src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 > src/tests/balloon_framework_test.sh > ae32753e8942f77f94752543c384d218d6e4d48d > > Diff: https://reviews.apache.org/r/45604/diff/ > > > Testing > ------- > > ``` > make check > > sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework" > ``` > > > Thanks, > > Joseph Wu > >
