----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45604/#review129962 -----------------------------------------------------------
This review could've used further splits. As a rule of thumb, if your description says there are 3 different things in this review, it is a strong indication that those 3 could have been done in their own reviews. src/examples/balloon_framework.cpp (lines 83 - 84) <https://reviews.apache.org/r/45604/#comment193525> Kill this line because it is required? src/examples/balloon_framework.cpp (line 136) <https://reviews.apache.org/r/45604/#comment193527> s/size of/resource limits set/ - Vinod Kone On April 19, 2016, 9:51 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45604/ > ----------------------------------------------------------- > > (Updated April 19, 2016, 9:51 p.m.) > > > Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and > Vinod Kone. > > > Bugs: MESOS-5174 > https://issues.apache.org/jira/browse/MESOS-5174 > > > Repository: mesos > > > Description > ------- > > This gives the example `balloon-framework` enough options to run > outside of the build environment. > > This also updates: > > * The style of the framework code. > * Adds an option for restricting the number of resources per task > (otherwise, it will eat up an entire node). > * Adds an option for persisting the framework and launching one task > after another. > * Adds filters for declined offers. > > > Diffs > ----- > > src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 > src/tests/balloon_framework_test.sh > a242f6cb9ca1850e5fef90e0938f41044bdaddbf > > Diff: https://reviews.apache.org/r/45604/diff/ > > > Testing > ------- > > ``` > make check > > sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework" > ``` > > > Thanks, > > Joseph Wu > >
