> On April 15, 2016, 2:13 p.m., Vinod Kone wrote:
> > src/examples/balloon_framework.cpp, lines 117-118
> > <https://reviews.apache.org/r/45604/diff/2-3/?file=1337948#file1337948line117>
> >
> >     why would they be incomplete?

There will be several metrics that count the number of tasks run (successfully 
or not) over time.  If the framework exits after one task, these counters will 
be meaningless (always 0).  I guess this is sort of implied, so I'll remove 
this line.


> On April 15, 2016, 2:13 p.m., Vinod Kone wrote:
> > src/examples/balloon_framework.cpp, lines 67-69
> > <https://reviews.apache.org/r/45604/diff/2-3/?file=1337948#file1337948line67>
> >
> >     Just change the type of  task_memory_usage_limit from Option<Bytes> to 
> > Bytes; no need for this validation then.

Counter-intuitively, specifying `Option<T>` with a lambda is how you specify a 
required argument.  A flag without an `Option<>` must have a default value, and 
is therefore an optional flag.  :)


> On April 15, 2016, 2:13 p.m., Vinod Kone wrote:
> > src/examples/balloon_framework.cpp, lines 85-91
> > <https://reviews.apache.org/r/45604/diff/2-3/?file=1337948#file1337948line85>
> >
> >     Ditto. Change `task_memory` to Bytes instead of Option<Bytes>.

Dropping for the same reason as above


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45604/#review129187
-----------------------------------------------------------


On April 19, 2016, 2:51 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45604/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 2:51 p.m.)
> 
> 
> Review request for mesos, Greg Mann, Artem Harutyunyan, Kevin Klues, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-5174
>     https://issues.apache.org/jira/browse/MESOS-5174
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives the example `balloon-framework` enough options to run
> outside of the build environment.
> 
> This also updates:
> 
> * The style of the framework code.
> * Adds an option for restricting the number of resources per task
>   (otherwise, it will eat up an entire node).
> * Adds an option for persisting the framework and launching one task
>   after another.
> * Adds filters for declined offers.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp 15c45612b777edaf97aea9b953439d4ad56920f3 
>   src/tests/balloon_framework_test.sh 
> a242f6cb9ca1850e5fef90e0938f41044bdaddbf 
> 
> Diff: https://reviews.apache.org/r/45604/diff/
> 
> 
> Testing
> -------
> 
> ```
> make check 
> 
> sudo bin/mesos-tests.sh --gtest_filter="*ROOT_CGROUPS_BalloonFramework"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to