> On April 22, 2016, 6:54 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 77 > > <https://reviews.apache.org/r/45370/diff/10/?file=1357453#file1357453line77> > > > > Should that be a hashset given that we don't allow duplicate? > > Guangya Liu wrote: > The problem is that `hashset` do not support using `DockerVolumeInfo` as > its value, so I was using a vector instead, any comments?
yeah, vector sounds fine. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review130133 ----------------------------------------------------------- On April 22, 2016, 4:08 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45370/ > ----------------------------------------------------------- > > (Updated April 22, 2016, 4:08 p.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Implemented prepare() for volume isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp > bedc687cc280d0b721fb84801039fd3614364cca > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > 915e5ae755a55a02b7dfcda88165f27346cad955 > src/slave/slave.cpp a365e8f5f8d63bf80614fccf6adf35a4fee07526 > > Diff: https://reviews.apache.org/r/45370/diff/ > > > Testing > ------- > > make > make check > > Will update `Sequence` later. > > > Thanks, > > Guangya Liu > >
