-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45370/#review129959
-----------------------------------------------------------



Thanks Guangya! This is great! Need to do one more pass later.


src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp (line 77)
<https://reviews.apache.org/r/45370/#comment193528>

    Should we use a hashset for `dockerVolumeInfos`?
    
    I am thinking if a user has two `DockerVolumleInfo` with exactly the same 
`dockerVolume`, `containerPath` and `driverOptions`, do we still bind mount 
them twice?



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 136)
<https://reviews.apache.org/r/45370/#comment193531>

    Mentioned before, please move the first space to above line. Thanks:)



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 141 - 
144)
<https://reviews.apache.org/r/45370/#comment193533>

    Not yours, just leave a note here.
    
    @jieyu, currently we have different places (e.g., slave.cpp, 
filesystem/linux.cpp, mesos/containerizer.cpp) explicitly exclude diff volume 
type.
    
    As we may have more volume types in the future, we should find a universal 
way to handle diff volume type exclussion.



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 152 - 
167)
<https://reviews.apache.org/r/45370/#comment193536>

    Why not merge these two `if`?



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 208)
<https://reviews.apache.org/r/45370/#comment193539>

    `foreach (...)`, plus a space:)



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 213)
<https://reviews.apache.org/r/45370/#comment193540>

    const string volumePath



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 259 - 
274)
<https://reviews.apache.org/r/45370/#comment193542>

    I would prefer remove `vector<string> messages` and return a failure once 
you get the first non-ready future. Please add necessary failure message.



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 279)
<https://reviews.apache.org/r/45370/#comment193543>

    ditto.



src/slave/slave.cpp (lines 3808 - 3813)
<https://reviews.apache.org/r/45370/#comment193522>

    Pull this out of `if (path::absolute(volume->container_path())) {...}`.


- Gilbert Song


On April 21, 2016, 7:21 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45370/
> -----------------------------------------------------------
> 
> (Updated April 21, 2016, 7:21 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented prepare() for volume isolator.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> bedc687cc280d0b721fb84801039fd3614364cca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
>   src/slave/slave.cpp d82dec2b10d496065013eb4ad6a35dc054b72553 
> 
> Diff: https://reviews.apache.org/r/45370/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> Will update `Sequence` later.
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to