----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45370/#review128946 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (line 111) <https://reviews.apache.org/r/45370/#comment192400> Shrink the first space to above line. src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 124 - 125) <https://reviews.apache.org/r/45370/#comment192406> We need a `if` to check here, otherwise it can cause segfault if `driver_options` is none. src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 127 - 134) <https://reviews.apache.org/r/45370/#comment192407> How about moving `.setContainerId(stringify(containerId))` next line? src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 164 - 165) <https://reviews.apache.org/r/45370/#comment192408> Save the raw cmd as a variable and pass this cmd to VLOG(1). - Gilbert Song On April 13, 2016, 11:29 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45370/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 11:29 p.m.) > > > Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and > Jie Yu. > > > Bugs: MESOS-5013 > https://issues.apache.org/jira/browse/MESOS-5013 > > > Repository: mesos > > > Description > ------- > > Implemented prepare() for volume isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/45370/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
