-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46621/#review130685
-----------------------------------------------------------




3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 386)
<https://reviews.apache.org/r/46621/#comment194539>

    use `->`  instead of .get(). here and everywhere else.



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 853)
<https://reviews.apache.org/r/46621/#comment194540>

    refactor this load (in a separate review) to be more readable.



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 999)
<https://reviews.apache.org/r/46621/#comment194542>

    instead of `--{a, b}=VALUE` do `--a=VALUE, --b=VALUE`



3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 1007)
<https://reviews.apache.org/r/46621/#comment194543>

    change the format of the usage to do it in the next line and change 
`=VALUE` to `=<value>`


- Vinod Kone


On April 26, 2016, 1:04 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46621/
> -----------------------------------------------------------
> 
> (Updated April 26, 2016, 1:04 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-5271
>     https://issues.apache.org/jira/browse/MESOS-5271
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added alias support for flags.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp 
> 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp 
> c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 
> 
> Diff: https://reviews.apache.org/r/46621/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to