> On May 5, 2016, 10:12 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, lines > > 828-830 > > <https://reviews.apache.org/r/46621/diff/5/?file=1367929#file1367929line828> > > > > ```cpp > > auto iter = aliases.count(flag_name) ? > > flags_.find(aliases[flag_name]) > > : flags_.find(flag_name); > > ```
that looks too jagged, no? i looked around in the code base and the most common style seem to indent "?" and ":" by 2 spaces from the start of the expression. will do the same here. > On May 5, 2016, 10:12 p.m., Michael Park wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 841 > > <https://reviews.apache.org/r/46621/diff/5/?file=1367929#file1367929line841> > > > > Why not just an lvalue-reference? IIRC, we prefer pointers to do non-const access instead of l-value reference in our code base. Has that changed? - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/#review131951 ----------------------------------------------------------- On April 30, 2016, 3:43 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46621/ > ----------------------------------------------------------- > > (Updated April 30, 2016, 3:43 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-5271 > https://issues.apache.org/jira/browse/MESOS-5271 > > > Repository: mesos > > > Description > ------- > > This lets a user to load a flag either by the original name or an > alias. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp > 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 > > Diff: https://reviews.apache.org/r/46621/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
