----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/#review131951 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp (line 22) <https://reviews.apache.org/r/46621/#comment195999> Doesn't look like we need this. 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp (lines 46 - 49) <https://reviews.apache.org/r/46621/#comment195998> Do we need this for anything aside from the instance of `set<Name>`? 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp (line 74) <https://reviews.apache.org/r/46621/#comment195997> `s/Name/const Name&/` 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 611 - 614) <https://reviews.apache.org/r/46621/#comment195993> Don't we or shouldn't we check that the flag name and the alias name are different? Regardless, we could still just do: ```cpp std::vector<Name> names = {flag.name}; if (flag.alias.isSome() && flag.alias.get() != flag.name) { names.push_back(flag.alias.get()); } ``` With this, I don't think we need to define a `operator<` for `Name`. 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (lines 828 - 830) <https://reviews.apache.org/r/46621/#comment195989> ```cpp auto iter = aliases.count(flag_name) ? flags_.find(aliases[flag_name]) : flags_.find(flag_name); ``` 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 841) <https://reviews.apache.org/r/46621/#comment195995> Why not just an lvalue-reference? - Michael Park On April 30, 2016, 3:43 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46621/ > ----------------------------------------------------------- > > (Updated April 30, 2016, 3:43 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-5271 > https://issues.apache.org/jira/browse/MESOS-5271 > > > Repository: mesos > > > Description > ------- > > This lets a user to load a flag either by the original name or an > alias. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp > 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 > > Diff: https://reviews.apache.org/r/46621/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
