----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46621/#review131245 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 841) <https://reviews.apache.org/r/46621/#comment195145> Why the raw pointer here? 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp (line 880) <https://reviews.apache.org/r/46621/#comment195144> Backticks around `loaded_name`? - Greg Mann On April 30, 2016, 3:43 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46621/ > ----------------------------------------------------------- > > (Updated April 30, 2016, 3:43 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-5271 > https://issues.apache.org/jira/browse/MESOS-5271 > > > Repository: mesos > > > Description > ------- > > This lets a user to load a flag either by the original name or an > alias. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flag.hpp > 2502d9e8a515b9adc1b3aa2f719e5710a0e7ef29 > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp > c3cbcdb781e1c282d381de1ad2bf4f386ee1db21 > > Diff: https://reviews.apache.org/r/46621/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
