----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/#review132125 -----------------------------------------------------------
src/master/http.cpp (line 869) <https://reviews.apache.org/r/46784/#comment196247> Did you need to pass all ("=") the in-scope variables through to the lambda, or just `request`? src/master/http.cpp (line 2846) <https://reviews.apache.org/r/46784/#comment196248> There's a lot of code duplication between here and `Slave::Http::authorizeEndpoint()`. Can you share/reuse code between the two? src/tests/master_authorization_tests.cpp (line 1036) <https://reviews.apache.org/r/46784/#comment196249> s/form/forms/ - Adam B On May 3, 2016, 5:42 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46784/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 5:42 a.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Bannier. > > > Bugs: MESOS-5297 > https://issues.apache.org/jira/browse/MESOS-5297 > > > Repository: mesos > > > Description > ------- > > Access to the '/flags' endpoint is authorized using > the 'GET_ENDPOINT_WITH_PATH' action. > > > Diffs > ----- > > src/master/http.cpp 4985f24b70a00116caa4bd0335ea51e55d878d19 > src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 > src/tests/master_authorization_tests.cpp > 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 > > Diff: https://reviews.apache.org/r/46784/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >