> On May 7, 2016, 12:24 p.m., Adam B wrote: > > src/master/http.cpp, line 869 > > <https://reviews.apache.org/r/46784/diff/3/?file=1369724#file1369724line869> > > > > Did you need to pass all ("=") the in-scope variables through to the > > lambda, or just `request`? > > Jan Schlicht wrote: > Yes, I only need to capture `request` here, but the way I understand the > C++ style guide, "default capture by value" ("=") is preferred over "explicit > capture by value". > > Alexander Rukletsov wrote: > I'm not sure this is what the styleguide says. I read "Prefer default > capture by value, explicit capture by value, then capture by reference." as > explicit and default captures both take precedence over captures by > reference. Anyway, if explicit capture is fine, this is the best use case for > it: a lambda taking one parameter, which is exactly your case. Please change > this.
Good to know. I'm actually a fan of explicit capture -- as long as the parameter list isn't too long. I've had a similar discussion with @bbannier about that above. There it's about the explicit capture of 2 parameters. I'll also change that there. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/#review132125 ----------------------------------------------------------- On May 3, 2016, 2:42 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46784/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 2:42 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Bannier. > > > Bugs: MESOS-5297 > https://issues.apache.org/jira/browse/MESOS-5297 > > > Repository: mesos > > > Description > ------- > > Access to the '/flags' endpoint is authorized using > the 'GET_ENDPOINT_WITH_PATH' action. > > > Diffs > ----- > > src/master/http.cpp 4985f24b70a00116caa4bd0335ea51e55d878d19 > src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 > src/tests/master_authorization_tests.cpp > 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 > > Diff: https://reviews.apache.org/r/46784/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
