----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46784/#review132228 -----------------------------------------------------------
Looks good! One more round and we can commit this. Do you want to add an integration test like you did in r/46203 with `AuthorizeFlagsEndpoint`? src/master/http.cpp (line 879) <https://reviews.apache.org/r/46784/#comment196403> In r/46203/ you've cached flags and passed them into continuation. Here you call `master->flags` in the continuation. Why is the approach different to the one for the agent? src/master/http.cpp (line 2872) <https://reviews.apache.org/r/46784/#comment196405> Why don't we return `MethodNotAllowed` here? Same applies to the agent, actually : ) src/tests/master_authorization_tests.cpp (line 1033) <https://reviews.apache.org/r/46784/#comment196407> Doesn't it compile without explicit casting to string? src/tests/master_authorization_tests.cpp (lines 1036 - 1037) <https://reviews.apache.org/r/46784/#comment196408> Please re-wrap to reduce jaggeddness. src/tests/master_authorization_tests.cpp (lines 1100 - 1101) <https://reviews.apache.org/r/46784/#comment196409> Ditto. - Alexander Rukletsov On May 3, 2016, 12:42 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46784/ > ----------------------------------------------------------- > > (Updated May 3, 2016, 12:42 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Bannier. > > > Bugs: MESOS-5297 > https://issues.apache.org/jira/browse/MESOS-5297 > > > Repository: mesos > > > Description > ------- > > Access to the '/flags' endpoint is authorized using > the 'GET_ENDPOINT_WITH_PATH' action. > > > Diffs > ----- > > src/master/http.cpp 4985f24b70a00116caa4bd0335ea51e55d878d19 > src/master/master.hpp 3e55114ee7866e06513071e86e15608099dae052 > src/tests/master_authorization_tests.cpp > 804b39a269c09df9f6c0bbdf6f8b53921ac09ce8 > > Diff: https://reviews.apache.org/r/46784/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
