-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46501/#review132138
-----------------------------------------------------------




docs/authorization.md (line 8)
<https://reviews.apache.org/r/46501/#comment196265>

    I think we could make clearer the separation between local 
authorizer-specific information and more general authorization information.
    
    I'd like to see the "Role vs. Principal" discussion brought back, perhaps 
included directly under this introduction.
    
    Then, another heading `## Local Authorizer` could be added, under which we 
include the remaining info which is specific to the local authorizer as 
sub-headings.
    
    Then, the final `## Implementing an Authorizer` heading.
    
    What do you think?



docs/authorization.md (line 14)
<https://reviews.apache.org/r/46501/#comment196266>

    s/no ACL were/no ACLs were/
    
    s/the specific action/that action/



docs/authorization.md (line 16)
<https://reviews.apache.org/r/46501/#comment196267>

    s/`Entity`objects/`Entity` objects/
    
    s/key to write/key to writing/



docs/authorization.md (line 18)
<https://reviews.apache.org/r/46501/#comment196268>

    s/`value` message/`value` field/
    
    s/its use to name/is used to name/
    
    How about: "The `value` message is an optional list of strings which holds 
the value of the `Entity` when `type` is set to `SOME`."
    
    If you use this version, you could switch the order and explain `type` 
first.



docs/authorization.md (line 27)
<https://reviews.apache.org/r/46501/#comment196264>

    Can we reintroduce the "Role vs. Principal" discussion?


- Greg Mann


On May 4, 2016, 8:39 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46501/
> -----------------------------------------------------------
> 
> (Updated May 4, 2016, 8:39 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Neil 
> Conway.
> 
> 
> Bugs: MESOS-4785
>     https://issues.apache.org/jira/browse/MESOS-4785
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The API of the authorization has been changing constantly over the
> last few versions. This patch attempts to update the documentation to
> the those changes into account.
> 
> 
> Diffs
> -----
> 
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
> 
> Diff: https://reviews.apache.org/r/46501/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to