> On May 10, 2016, 8:36 p.m., Greg Mann wrote: > > docs/authorization.md, line 66 > > <https://reviews.apache.org/r/46501/diff/6/?file=1376304#file1376304line66> > > > > I find it a bit confusing that we explain the `permissive` field first > > here, when the other fields are really the focus of the documentation. I > > might steal the JSON-based bit from the previous sentence and say: "ACLs > > can be described with a JSON-based language that provides a field for each > > authorizable action. An additional `permissive` field determines the > > authorizer's behavior when no matching ACL can be found." What do you think?
I moved a modified version of this paragraph to the end of the ACLs description. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review132501 ----------------------------------------------------------- On May 9, 2016, 12:49 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46501/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 12:49 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Neil > Conway. > > > Bugs: MESOS-4785 > https://issues.apache.org/jira/browse/MESOS-4785 > > > Repository: mesos > > > Description > ------- > > The API of the authorization has been changing constantly over the > last few versions. This patch attempts to update the documentation to > the those changes into account. > > > Diffs > ----- > > docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 > > Diff: https://reviews.apache.org/r/46501/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Rojas > >
