This is an automatically generated e-mail. To reply, visit:

docs/authorization.md (line 10)

    s/but alternative implementations.../but alternative implementations could 
express their authorization rules in different ways/

docs/authorization.md (line 12)

    s/divided in two/divided into two/
    s/The second, briefly/The second briefly/
    s/custom authorizer. This section is/custom authorizer; this section is/

docs/authorization.md (line 32)

    I find it a bit confusing that we explain the `permissive` field first 
here, when the other fields are really the focus of the documentation. I might 
steal the JSON-based bit from the previous sentence and say: "ACLs can be 
described with a JSON-based language that provides a field for each 
authorizable action. An additional `permissive` field determines the 
authorizer's behavior when no matching ACL can be found." What do you think?

docs/authorization.md (line 34)

    s/Both entries ... object as `Entity`./Both entries are specified with the 
same type of JSON object, known as an `Entity`./

docs/authorization.md (line 36)

    This might be easier to understand if we begin with a simple sentence 
explaining the `Entity` in less abstract terms: "An `Entity` is essentially a 
container which can either hold a particular value or specify the special 
values `ANY` or `NONE`."

docs/authorization.md (line 41)

    Can we state explicitly here that this means the order in which a user 
specifies ACLs may impact how they behave? It's good that we mention it in the 
examples section later on, but mentioning it here briefly would be good too I 

docs/authorization.md (line 45)

    s/support the following/supports the following/

docs/authorization.md (line 62)

    close the parantheses

docs/authorization.md (line 231)


- Greg Mann

On May 9, 2016, 10:49 a.m., Alexander Rojas wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46501/
> -----------------------------------------------------------
> (Updated May 9, 2016, 10:49 a.m.)
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Neil 
> Conway.
> Bugs: MESOS-4785
>     https://issues.apache.org/jira/browse/MESOS-4785
> Repository: mesos
> Description
> -------
> The API of the authorization has been changing constantly over the
> last few versions. This patch attempts to update the documentation to
> the those changes into account.
> Diffs
> -----
>   docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 
> Diff: https://reviews.apache.org/r/46501/diff/
> Testing
> -------
> Thanks,
> Alexander Rojas

Reply via email to