-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47095/#review132190
-----------------------------------------------------------




src/tests/containerizer/mesos_containerizer_tests.cpp (line 1064)
<https://reviews.apache.org/r/47095/#comment196352>

    s/MESOS_SANDBOX/`MESOS_SANDBOX`



src/tests/containerizer/provisioner_docker_tests.cpp (line 560)
<https://reviews.apache.org/r/47095/#comment196354>

    s/ROOT_MesosSandboxEnv/ROOT_INTERNET_CURL_MesosSandboxEnv
    
    The test will be failed in China due to GFW, so we need to add INTERNET 
filter here.



src/tests/containerizer/provisioner_docker_tests.cpp (line 571)
<https://reviews.apache.org/r/47095/#comment196353>

    we can remove this as it is the default value



src/tests/containerizer/provisioner_docker_tests.cpp (lines 601 - 608)
<https://reviews.apache.org/r/47095/#comment196355>

    You can use below to replace it.
    
    TaskInfo task = createTask(
        offer.slave_id(),
        Resources::parse("cpus:1;mem:128").get(),
        "echo -n $MESOS_SANDBOX > $MESOS_SANDBOX/env.txt");


- Guangya Liu


On 五月 8, 2016, 11:47 a.m., Shuai Lin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47095/
> -----------------------------------------------------------
> 
> (Updated 五月 8, 2016, 11:47 a.m.)
> 
> 
> Review request for mesos, Guangya Liu and Jie Yu.
> 
> 
> Bugs: MESOS-5312
>     https://issues.apache.org/jira/browse/MESOS-5312
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for MESOS_SANDBOX env for unified containerizer.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 09742ff21513dc2570684d384b257868dd57a9ce 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 69505c922617273effc2eb52b0c567a3c01bf640 
> 
> Diff: https://reviews.apache.org/r/47095/diff/
> 
> 
> Testing
> -------
> 
> "make check" on ubuntu 14.04 64bit with gcc 4.8.4
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Reply via email to