> On May 9, 2016, 5:59 a.m., Guangya Liu wrote: > > src/tests/containerizer/mesos_containerizer_tests.cpp, line 1065 > > <https://reviews.apache.org/r/47095/diff/2/?file=1375993#file1375993line1065> > > > > s/SandboxEnv/ContainerSandboxEnv ?
I prefer `MesosSandboxEnv`, since that's what's being tested. - Shuai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47095/#review132207 ----------------------------------------------------------- On May 9, 2016, 3:51 a.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47095/ > ----------------------------------------------------------- > > (Updated May 9, 2016, 3:51 a.m.) > > > Review request for mesos, Guangya Liu and Jie Yu. > > > Bugs: MESOS-5312 > https://issues.apache.org/jira/browse/MESOS-5312 > > > Repository: mesos > > > Description > ------- > > Added tests for MESOS_SANDBOX env for unified containerizer. > > > Diffs > ----- > > src/tests/containerizer/mesos_containerizer_tests.cpp > 09742ff21513dc2570684d384b257868dd57a9ce > src/tests/containerizer/provisioner_docker_tests.cpp > 69505c922617273effc2eb52b0c567a3c01bf640 > > Diff: https://reviews.apache.org/r/47095/diff/ > > > Testing > ------- > > "make check" on ubuntu 14.04 64bit with gcc 4.8.4 > > > Thanks, > > Shuai Lin > >
