-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47505/#review133707
-----------------------------------------------------------
Additionally, you should also update the local authorizer implementation,
specifically
```
Future<bool> authorized(
const authorization::Request& request,
const vector<GenericACL>& acls)
```
Currently, we do not call `has_*()`, meaning we use default instances, which do
the job in our case, but explicit calls to `has_*()` are cleaner, especially if
we are going to upgrade the messages in the future.
include/mesos/authorizer/authorizer.proto (line 28)
<https://reviews.apache.org/r/47505/#comment198296>
As per comment on MESOS-5405, I think it is fine that we have two ways of
expressing {{ANY}}. We are doing it already in our code, illegally ; ). Please
change it back to optional.
Also, please return the comment back, with a minor change:
s/unknown/unspecified.
include/mesos/authorizer/authorizer.proto (line 38)
<https://reviews.apache.org/r/47505/#comment198297>
Ditto.
include/mesos/authorizer/authorizer.proto (line 67)
<https://reviews.apache.org/r/47505/#comment198298>
s/unknown/unspecified
- Alexander Rukletsov
On May 18, 2016, 12:35 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47505/
> -----------------------------------------------------------
>
> (Updated May 18, 2016, 12:35 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, and
> Vinod Kone.
>
>
> Bugs: MESOS-5405
> https://issues.apache.org/jira/browse/MESOS-5405
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Makes `value` required for clearity, to make sure that we do not
> introduce two ways of expressing `ANY`.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/authorizer.proto
> 7d4aa32f42de538864508a0ba481d875917d9ab9
>
> Diff: https://reviews.apache.org/r/47505/diff/
>
>
> Testing
> -------
>
> make check (OSX)
>
>
> Thanks,
>
> Till Toenshoff
>
>
