----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47505/#review135665 -----------------------------------------------------------
Fix it, then Ship it! Update your Request.subject/object comments to be consistent, then commit it! include/mesos/authorizer/authorizer.proto (lines 99 - 105) <https://reviews.apache.org/r/47505/#comment200672> I'd make the subject/object comments nearly identical, perhaps: An unset `subject|object` means "unspecified". - Adam B On May 31, 2016, 11:28 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47505/ > ----------------------------------------------------------- > > (Updated May 31, 2016, 11:28 a.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, and > Vinod Kone. > > > Bugs: MESOS-5405 > https://issues.apache.org/jira/browse/MESOS-5405 > > > Repository: mesos > > > Description > ------- > > `Subject` and `Object` are now optional fields. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.proto 0142476 > > Diff: https://reviews.apache.org/r/47505/diff/ > > > Testing > ------- > > make check (OSX) > > > Thanks, > > Till Toenshoff > >
