> On May 18, 2016, 8:30 a.m., Alexander Rukletsov wrote: > > include/mesos/authorizer/authorizer.proto, line 29 > > <https://reviews.apache.org/r/47505/diff/1/?file=1386256#file1386256line29> > > > > As per comment on MESOS-5405, I think it is fine that we have two ways > > of expressing {{ANY}}. We are doing it already in our code, illegally ; ). > > Please change it back to optional. > > > > Also, please return the comment back, with a minor change: > > s/unknown/unspecified.
GIven that we want to keep the door open for a union-style object and maybe even subject, I think using the !has_value() for signalling ANY is wrong and should at least be explicitely discouraged. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47505/#review133707 ----------------------------------------------------------- On May 31, 2016, 5:59 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47505/ > ----------------------------------------------------------- > > (Updated May 31, 2016, 5:59 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, and > Vinod Kone. > > > Bugs: MESOS-5405 > https://issues.apache.org/jira/browse/MESOS-5405 > > > Repository: mesos > > > Description > ------- > > Makes `value` required for clearity, to make sure that we do not > introduce two ways of expressing `ANY`. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.proto 0142476 > > Diff: https://reviews.apache.org/r/47505/diff/ > > > Testing > ------- > > make check (OSX) > > > Thanks, > > Till Toenshoff > >
