> On May 18, 2016, 8:30 a.m., Alexander Rukletsov wrote: > > Additionally, you should also update the local authorizer implementation, > > specifically > > ``` > > Future<bool> authorized( > > const authorization::Request& request, > > const vector<GenericACL>& acls) > > ``` > > Currently, we do not call `has_*()`, meaning we use default instances, > > which do the job in our case, but explicit calls to `has_*()` are cleaner, > > especially if we are going to upgrade the messages in the future.
Yup, follow-up coming. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47505/#review133707 ----------------------------------------------------------- On May 31, 2016, 5:59 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47505/ > ----------------------------------------------------------- > > (Updated May 31, 2016, 5:59 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Alexander Rojas, and > Vinod Kone. > > > Bugs: MESOS-5405 > https://issues.apache.org/jira/browse/MESOS-5405 > > > Repository: mesos > > > Description > ------- > > Makes `value` required for clearity, to make sure that we do not > introduce two ways of expressing `ANY`. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.proto 0142476 > > Diff: https://reviews.apache.org/r/47505/diff/ > > > Testing > ------- > > make check (OSX) > > > Thanks, > > Till Toenshoff > >
