----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46501/#review133711 -----------------------------------------------------------
Fix it, then Ship it! I've wrapped the text and did a final pass. I'll fix the outstanding issues and commit this for you shortly. docs/authorization.md (line 10) <https://reviews.apache.org/r/46501/#comment198302> s/, but/. docs/authorization.md (line 12) <https://reviews.apache.org/r/46501/#comment198304> s/but to programmers/but at engineers docs/authorization.md (line 18) <https://reviews.apache.org/r/46501/#comment198303> The analogy is not precise, killing that extra. docs/authorization.md (line 24) <https://reviews.apache.org/r/46501/#comment198305> * The master consults the local authorizer, which in turn... s/, so the framework/, the framework docs/authorization.md (line 36) <https://reviews.apache.org/r/46501/#comment198306> s/no ACL apply/no ACL applies docs/authorization.md (lines 46 - 57) <https://reviews.apache.org/r/46501/#comment198307> According to https://mesos.apache.org/documentation/latest/markdown-style-guide/ , we should use HTML tables. Could you please follow-up with the fix? Feel free to publish a review without a JIRA ticket. Thanks! docs/authorization.md (line 57) <https://reviews.apache.org/r/46501/#comment198308> We should add an entry for `get_endpoints` docs/authorization.md (lines 486 - 500) <https://reviews.apache.org/r/46501/#comment198314> It's hard to remember that this doc should be updated if changes to the proto are made. Can we reference the code instead? Could you please follow up with a fix? docs/authorization.md (line 502) <https://reviews.apache.org/r/46501/#comment198312> Remove trailing space. - Alexander Rukletsov On May 17, 2016, 1:11 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46501/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 1:11 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Neil > Conway. > > > Bugs: MESOS-4785 > https://issues.apache.org/jira/browse/MESOS-4785 > > > Repository: mesos > > > Description > ------- > > The API of the authorization has been changing constantly over the > last few versions. This patch attempts to update the documentation to > the those changes into account. > > > Diffs > ----- > > docs/authorization.md 0db5c345b3239814b3b9d2e8a87601ff69d0f869 > > Diff: https://reviews.apache.org/r/46501/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Rojas > >
