> On Cze 21, 2016, 9:32 po południu, Benjamin Mahler wrote: > > Very nice, however the meaning of the color doesn't seem discoverable. Do > > we also need a legend or an explicit field to indicate the state? > > Tomasz Janiszewski wrote: > How about adding "Connected" column with plain true/false or status icon? > > Benjamin Mahler wrote: > Hm.. well the title of this table is "Active Frameworks", and > disconnected frameworks are not "active". So we could also add another table > here to hold the disconnected frameworks.. thoughts?
So as it is described in jira and I think it's the cleanest solution. I'll update this patch later this week. - Tomasz ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review138945 ----------------------------------------------------------- On Cze 18, 2016, 7:16 po południu, Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48910/ > ----------------------------------------------------------- > > (Updated Cze 18, 2016, 7:16 po południu) > > > Review request for mesos, Benjamin Mahler, Deshna Jain, haosdent huang, Ross > Allen, and Vinod Kone. > > > Bugs: MESOS-2145 > https://issues.apache.org/jira/browse/MESOS-2145 > > > Repository: mesos > > > Description > ------- > > When framework is active but no alive, it's row > become highlighted with reddish background. > > > Diffs > ----- > > src/webui/master/static/frameworks.html > cfb6f4efc259419e4cb697332c8d6f2839e96970 > > Diff: https://reviews.apache.org/r/48910/diff/ > > > Testing > ------- > >  > > Run framework (e.g. Marathon) wait until it appear on `#/frameworks`. Stop it > (no graceful shutdown with deregistration). It should be highlighted with > next page update. > > > Thanks, > > Tomasz Janiszewski > >
