> On June 27, 2016, 3:49 a.m., Vinod Kone wrote:
> > src/webui/master/static/frameworks.html, line 29
> > <https://reviews.apache.org/r/48910/diff/2/?file=1430180#file1430180line29>
> >
> > should be filtered by `disconnected` boolean.
> >
> > a framework in master has two tags associated with it, `active` and
> > `connected`. so the following 4 states are theoretically possible:
> >
> > connected and active
> > connected but inactive (not currently possible but maybe in the future)
> > disconnected and active (doesn't make sense)
> > disconnected and inactive
>
> Tomasz Janiszewski wrote:
> I'm on latest master `git_sha:
> "05b553ec6b0260547055fbc807ab3acce4ece234"`. There is no `disconnected` field
> in frameworks returned by `/master/state`. On the other hand
> `/metrics/snapshot` has fields `master/frameworks_connected` and
> `master/frameworks_disconnected`. Should I add this fields to `/master/state`
> endpoint?
Adding connected field looks easy but I can't find tests for this part of code.
```
diff --git a/src/master/http.cpp b/src/master/http.cpp
index d55aa05..7c1008d 100644
--- a/src/master/http.cpp
+++ b/src/master/http.cpp
@@ -367,6 +367,7 @@ static void json(JSON::ObjectWriter* writer, const
Summary<Framework>& summary)
writer->field("hostname", framework.info.hostname());
writer->field("webui_url", framework.info.webui_url());
writer->field("active", framework.active);
+ writer->field("connected", framework.connected);
}
```
- Tomasz
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48910/#review139516
-----------------------------------------------------------
On June 25, 2016, 3:48 p.m., Tomasz Janiszewski wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48910/
> -----------------------------------------------------------
>
> (Updated June 25, 2016, 3:48 p.m.)
>
>
> Review request for mesos, Benjamin Mahler, Deshna Jain, haosdent huang, Ross
> Allen, and Vinod Kone.
>
>
> Bugs: MESOS-2145
> https://issues.apache.org/jira/browse/MESOS-2145
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Create 3 groups in fameworks listing for connected,
> disconnected and completed frameworks.
>
>
> Diffs
> -----
>
> src/webui/master/static/frameworks.html
> cfb6f4efc259419e4cb697332c8d6f2839e96970
>
> Diff: https://reviews.apache.org/r/48910/diff/
>
>
> Testing
> -------
>
> 
>
> Run framework (e.g. Marathon) wait until it appear on `#/frameworks`. Stop it
> (no graceful shutdown with deregistration). It should be highlighted with
> next page update.
>
>
> Thanks,
>
> Tomasz Janiszewski
>
>
