-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48910/#review139696
-----------------------------------------------------------


Ship it!





src/webui/master/static/frameworks.html (line 8)
<https://reviews.apache.org/r/48910/#comment205009>

    why the change in capitalization of "frameworks"? it is consistent with how 
we capitalized "Active Tasks" and "Completed Tasks"? I'll fix it while 
committing.


- Vinod Kone


On June 27, 2016, 7:19 p.m., Tomasz Janiszewski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48910/
> -----------------------------------------------------------
> 
> (Updated June 27, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Deshna Jain, haosdent huang, Ross 
> Allen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2145
>     https://issues.apache.org/jira/browse/MESOS-2145
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Create 3 groups in fameworks listing for active,
> inactive and completed frameworks.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/frameworks.html 
> cfb6f4efc259419e4cb697332c8d6f2839e96970 
> 
> Diff: https://reviews.apache.org/r/48910/diff/
> 
> 
> Testing
> -------
> 
> ![screenshot](https://issues.apache.org/jira/secure/attachment/12813382/frameworks_alive.png)
> 
> Run framework (e.g. Marathon) wait until it appear on `#/frameworks`. Stop it 
> (no graceful shutdown with deregistration). It should be highlighted with 
> next page update.
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Reply via email to