----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48910/#review139516 -----------------------------------------------------------
Fix it, then Ship it! src/webui/master/static/frameworks.html (line 29) <https://reviews.apache.org/r/48910/#comment204784> should be filtered by `disconnected` boolean. a framework in master has two tags associated with it, `active` and `connected`. so the following 4 states are theoretically possible: connected and active connected but inactive (not currently possible but maybe in the future) disconnected and active (doesn't make sense) disconnected and inactive src/webui/master/static/frameworks.html (line 87) <https://reviews.apache.org/r/48910/#comment204785> s/active/connected/ - Vinod Kone On June 25, 2016, 3:48 p.m., Tomasz Janiszewski wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48910/ > ----------------------------------------------------------- > > (Updated June 25, 2016, 3:48 p.m.) > > > Review request for mesos, Benjamin Mahler, Deshna Jain, haosdent huang, Ross > Allen, and Vinod Kone. > > > Bugs: MESOS-2145 > https://issues.apache.org/jira/browse/MESOS-2145 > > > Repository: mesos > > > Description > ------- > > Create 3 groups in fameworks listing for connected, > disconnected and completed frameworks. > > > Diffs > ----- > > src/webui/master/static/frameworks.html > cfb6f4efc259419e4cb697332c8d6f2839e96970 > > Diff: https://reviews.apache.org/r/48910/diff/ > > > Testing > ------- > >  > > Run framework (e.g. Marathon) wait until it appear on `#/frameworks`. Stop it > (no graceful shutdown with deregistration). It should be highlighted with > next page update. > > > Thanks, > > Tomasz Janiszewski > >
