----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review139436 -----------------------------------------------------------
src/tests/containerizer/provisioner_appc_tests.cpp (line 318) <https://reviews.apache.org/r/49208/#comment204667> two spaces and the following format also needs to be udpated src/tests/containerizer/provisioner_appc_tests.cpp (line 327) <https://reviews.apache.org/r/49208/#comment204668> adjust the format here src/tests/containerizer/provisioner_appc_tests.cpp (lines 589 - 604) <https://reviews.apache.org/r/49208/#comment204669> Not yours, but I think that the format here also needs to be upated as https://github.com/apache/mesos/blob/master/src/tests/containerizer/provisioner_appc_tests.cpp#L286-L301 src/tests/containerizer/provisioner_appc_tests.cpp (lines 605 - 607) <https://reviews.apache.org/r/49208/#comment204666> Are you missing `exec` and `environment` here? src/tests/containerizer/provisioner_appc_tests.cpp (line 809) <https://reviews.apache.org/r/49208/#comment204670> Not adjust here but the following fields as https://github.com/apache/mesos/blob/master/src/tests/containerizer/provisioner_appc_tests.cpp#L286-L301 src/tests/containerizer/provisioner_appc_tests.cpp (line 825) <https://reviews.apache.org/r/49208/#comment204671> ditto src/tests/containerizer/provisioner_appc_tests.cpp (line 826) <https://reviews.apache.org/r/49208/#comment204675> two spaces alignment with line 808 src/tests/containerizer/provisioner_appc_tests.cpp (lines 826 - 838) <https://reviews.apache.org/r/49208/#comment204676> two spaces alignment with line 808 - Guangya Liu On 六月 24, 2016, 9:56 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49208/ > ----------------------------------------------------------- > > (Updated 六月 24, 2016, 9:56 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4778 > https://issues.apache.org/jira/browse/MESOS-4778 > > > Repository: mesos > > > Description > ------- > > Modified tests to check is appc spec with app object is properly parsed. > > > Diffs > ----- > > src/tests/containerizer/provisioner_appc_tests.cpp > 061f80c62319817b22a5c1880a4858fdafbfb72a > > Diff: https://reviews.apache.org/r/49208/diff/ > > > Testing > ------- > > Make check > > > Thanks, > > Srinivas Brahmaroutu > >
