----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49208/#review139777 -----------------------------------------------------------
src/Makefile.am (lines 2097 - 2098) <https://reviews.apache.org/r/49208/#comment205121> adjust the order here src/tests/containerizer/appc_spec_tests.cpp (line 32) <https://reviews.apache.org/r/49208/#comment205123> It's already in its own test file ;-) src/tests/containerizer/appc_spec_tests.cpp (line 81) <https://reviews.apache.org/r/49208/#comment205125> period to the end src/tests/containerizer/appc_spec_tests.cpp (lines 84 - 85) <https://reviews.apache.org/r/49208/#comment205124> Also validate the `size` as `1`? src/tests/containerizer/appc_spec_tests.cpp (line 90) <https://reviews.apache.org/r/49208/#comment205126> period to the end - Guangya Liu On 六月 28, 2016, 5:05 a.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49208/ > ----------------------------------------------------------- > > (Updated 六月 28, 2016, 5:05 a.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4778 > https://issues.apache.org/jira/browse/MESOS-4778 > > > Repository: mesos > > > Description > ------- > > Added tests to check if appc spec is properly parsed. > > > Diffs > ----- > > src/Makefile.am 23cac95a805e46d216e9479fea09f2c1619c45a5 > src/tests/containerizer/appc_spec_tests.cpp PRE-CREATION > src/tests/containerizer/provisioner_appc_tests.cpp > 061f80c62319817b22a5c1880a4858fdafbfb72a > > Diff: https://reviews.apache.org/r/49208/diff/ > > > Testing > ------- > > Make check > > > Thanks, > > Srinivas Brahmaroutu > >
