----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/#review141741 -----------------------------------------------------------
Could you address Guangya's comments? Thanks. src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 266) <https://reviews.apache.org/r/49348/#comment207125> Please fix this comment. src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 267) <https://reviews.apache.org/r/49348/#comment207124> no need this logic here. src/slave/containerizer/mesos/isolators/appc/runtime.cpp (line 275) <https://reviews.apache.org/r/49348/#comment207126> Newline above. src/slave/containerizer/mesos/isolators/appc/runtime.cpp (lines 286 - 287) <https://reviews.apache.org/r/49348/#comment207099> Could we double check this one in an Appc image? - Gilbert Song On July 5, 2016, 11:32 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49348/ > ----------------------------------------------------------- > > (Updated July 5, 2016, 11:32 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-4778 > https://issues.apache.org/jira/browse/MESOS-4778 > > > Repository: mesos > > > Description > ------- > > Added implementation to Appc Runtime Isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/49348/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Srinivas Brahmaroutu > >
