> On July 6, 2016, 11:38 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/appc/runtime.cpp, line 265 > > <https://reviews.apache.org/r/49348/diff/6/?file=1437512#file1437512line265> > > > > Seems you are losing the logic to handle logic in row 2 when there are > > arguments? > > Gilbert Song wrote: > The logic seems fine to me here. That case is covered. > > Guangya Liu wrote: > Seems this will only cover line 1 but not line 2, comments?
We dont need to do anything special to line 2. Could you verify? I can be wrong. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49348/#review141133 ----------------------------------------------------------- On July 12, 2016, 9:15 a.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49348/ > ----------------------------------------------------------- > > (Updated July 12, 2016, 9:15 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-4778 > https://issues.apache.org/jira/browse/MESOS-4778 > > > Repository: mesos > > > Description > ------- > > Added implementation to Appc Runtime Isolator. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/appc/runtime.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/49348/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Srinivas Brahmaroutu > >
