----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review144706 -----------------------------------------------------------
src/docker/docker.hpp (lines 73 - 75) <https://reviews.apache.org/r/50128/#comment210749> s/std::string/const std::string& src/docker/docker.hpp (line 85) <https://reviews.apache.org/r/50128/#comment210752> new line for the brace src/docker/docker.hpp (line 95) <https://reviews.apache.org/r/50128/#comment210753> new line for the brace src/docker/docker.hpp (line 96) <https://reviews.apache.org/r/50128/#comment210751> Put include for vector to the top. ``` #include <vector> ``` - Guangya Liu On 八月 2, 2016, 2:19 p.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50128/ > ----------------------------------------------------------- > > (Updated 八月 2, 2016, 2:19 p.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Wrapped helper functions 'serialize()' and 'parse()' to 'Docker::Device' > to handle data tranformation between 'Docker::Device' structure and > string. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 > > Diff: https://reviews.apache.org/r/50128/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
