----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review145058 -----------------------------------------------------------
src/docker/docker.hpp (line 20) <https://reviews.apache.org/r/50128/#comment211226> move this under line 22 to keep alpia order. src/docker/docker.hpp (lines 74 - 76) <https://reviews.apache.org/r/50128/#comment211222> Why not use a reference here? ``` const std::string& host, const std::string& container, const std::string& permissions ``` - Guangya Liu On 八月 5, 2016, 9:58 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50128/ > ----------------------------------------------------------- > > (Updated 八月 5, 2016, 9:58 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Wrapped helper functions 'serialize()' and 'parse()' to 'Docker::Device' > to handle data tranformation between 'Docker::Device' structure and > string. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp e8d2cb9662af34d75c9e2d822004f58fac76e7e0 > > Diff: https://reviews.apache.org/r/50128/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
