----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51172/#review146298 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/volume/image.hpp (lines 52 - 53) <https://reviews.apache.org/r/51172/#comment212666> Nit, it is better include those headers explicitly. We generally don't rely on transitive includes as it's harder to maintain which includes are needed. I posted a patch to fix such issue for `sorter.hpp` at https://reviews.apache.org/r/48455/ , so it would be great if we can follow such style for all patches. src/slave/containerizer/mesos/isolators/volume/image.cpp (line 150) <https://reviews.apache.org/r/51172/#comment212667> `const` here? - Guangya Liu On 八月 22, 2016, 2:13 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51172/ > ----------------------------------------------------------- > > (Updated 八月 22, 2016, 2:13 a.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, Artem > Harutyunyan, Jie Yu, Kevin Klues, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This is a followup patch for r/51141, to move the image volumes > support from the mesos containerizer to the 'volume/image' isolator. > > > Diffs > ----- > > src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > src/slave/containerizer/mesos/isolators/volume/image.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/image.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51172/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
