----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51172/#review146256 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/volume/image.cpp (lines 89 - 92) <https://reviews.apache.org/r/51172/#comment212610> What about move those definitions right before L162 where they were used? src/slave/containerizer/mesos/isolators/volume/image.cpp (line 91) <https://reviews.apache.org/r/51172/#comment212608> It is better include the `vector` namespace in the header of this file. ``` #include <vector> ``` ``` using std::vector; ``` src/slave/containerizer/mesos/isolators/volume/image.cpp (line 106) <https://reviews.apache.org/r/51172/#comment212611> I think we do not need to speicify the `docker volume` here. src/slave/containerizer/mesos/isolators/volume/image.cpp (line 111) <https://reviews.apache.org/r/51172/#comment212612> ditto - Guangya Liu On 八月 17, 2016, 8:44 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51172/ > ----------------------------------------------------------- > > (Updated 八月 17, 2016, 8:44 a.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, Artem > Harutyunyan, Jie Yu, Kevin Klues, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Implemented the volume/image isolator. > > > Diffs > ----- > > src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > src/slave/containerizer/mesos/isolators/volume/image.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/image.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51172/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
