> On Aug. 18, 2016, 4:37 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/volume/image.cpp, line 94 > > <https://reviews.apache.org/r/51172/diff/1/?file=1476389#file1476389line94> > > > > s/int/size_t
Please see mesos.pb.h > On Aug. 18, 2016, 4:37 p.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolators/volume/image.cpp, lines 97-99 > > <https://reviews.apache.org/r/51172/diff/1/?file=1476389#file1476389line97> > > > > I think that we also need to check if the volume has source here, and > > just ignore such volumes as the volume who has sources can only be handled > > by docker volume isolator. > > > > ``` > > if (volume.has_source()) { > > ... > > } > > ``` The IMAGE check is enough. We will refactor in the future when moving to SOURCE. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51172/#review146146 ----------------------------------------------------------- On Aug. 21, 2016, 7:13 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51172/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2016, 7:13 p.m.) > > > Review request for mesos, Benjamin Hindman, Benjamin Mahler, Artem > Harutyunyan, Jie Yu, Kevin Klues, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This is a followup patch for r/51141, to move the image volumes > support from the mesos containerizer to the 'volume/image' isolator. > > > Diffs > ----- > > src/CMakeLists.txt 4362d472707193aa09343ef69f070e2d3efda324 > src/Makefile.am d389e02584cfb1a00067cd30de1364118d1c46c7 > src/slave/containerizer/mesos/isolators/volume/image.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/image.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51172/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
