> On Aug. 25, 2016, 3:22 a.m., Jiang Yan Xu wrote: > > src/tests/sorter_tests.cpp, lines 773-779 > > <https://reviews.apache.org/r/45961/diff/14/?file=1472401#file1472401line773> > > > > Doesn't look like this block with `e` add much to the test coverage, > > remove it?
I removed 'd' and renamed 'e' as 'd'. I think we can keep 'd' (originally 'e') as it allows to show comparison between 3 clients when 1 of the clients is deactivated. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review146046 ----------------------------------------------------------- On Aug. 29, 2016, 7:21 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45961/ > ----------------------------------------------------------- > > (Updated Aug. 29, 2016, 7:21 a.m.) > > > Review request for mesos, Benjamin Mahler, Joris Van Remoortere, Michael > Park, and Jiang Yan Xu. > > > Bugs: MESOS-4431 > https://issues.apache.org/jira/browse/MESOS-4431 > > > Repository: mesos > > > Description > ------- > > o Each shared resource is accouted via its share count. This count is > updated based on the resource operations (such as add and subtract) > in various scenarios such as task launch and terminate at multiple > modules such as master, allocator, sorter, etc. > o Only allow DESTROY if there are no running or pending tasks using > the volume. However, if the volume is in a pending offer to one or > more frameworks, rescind that offer before processing the DESTROY. > o To allow multiple tasks to be launched in the same ACCEPT call > using the same shared resource, we update the allocator and > sorter with additional copies of shared resources to reflect the > true shared count of allocated shared resources. > > > Diffs > ----- > > src/common/resources.cpp a5f5902d8f7f2757e3aee35619bff5cc3a52f29b > src/common/resources_utils.cpp 8e881a09500b0966b577e514077460f724868a8d > src/master/allocator/mesos/hierarchical.hpp > bdbc6d3b5b959990538f4e3b7b1a3b031d9aea05 > src/master/allocator/mesos/hierarchical.cpp > 234ef98529964a0b6d3f132426a6c8ccbb1263ee > src/master/allocator/sorter/drf/sorter.hpp > bc6bfb2d5d3b32d55be055a0514861b4e7d889bb > src/master/allocator/sorter/drf/sorter.cpp > ac85b327fc33d34246788e6a8c8bf5a486c61434 > src/master/http.cpp 525ef6cd7545d25f3ac89a6325ace6e6d768262a > src/master/master.hpp b118293823d37bba9b751aac12e0403318ce5736 > src/master/master.cpp 2b4aff80385d02c71dc3eeff4ddda326c9824ede > src/master/validation.hpp 3205ee1e699d0fb7ca16ced96a07be3a07cf8956 > src/master/validation.cpp 15e2ecc2de99d6bed522f45f855ba686bf19c008 > src/tests/master_validation_tests.cpp > e440ff3f6d04f797e65874b9f610ed63d9f28e0e > src/tests/sorter_tests.cpp 821e30d6574b045d25d4de4f7c3b8ac5346d3002 > src/v1/resources.cpp 172217505d80d66cb7e10b3635dc273229313601 > > Diff: https://reviews.apache.org/r/45961/diff/ > > > Testing > ------- > > Tests successful. > > > Thanks, > > Anindya Sinha > >
