----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/#review148024 -----------------------------------------------------------
Ship it! Minor things that I'll take care of when committing. src/master/allocator/mesos/hierarchical.cpp (lines 675 - 679) <https://reviews.apache.org/r/45961/#comment215382> ``` s/additional instances of shared resources/additional instances of the same shared resources/ ``` src/master/allocator/mesos/hierarchical.cpp (line 1361) <https://reviews.apache.org/r/45961/#comment215383> s/cycle/stage/ src/master/allocator/sorter/drf/sorter.cpp (line 163) <https://reviews.apache.org/r/45961/#comment215384> s/total/allocated/ src/master/allocator/sorter/drf/sorter.cpp (lines 165 - 168) <https://reviews.apache.org/r/45961/#comment215385> Changed the indentation style to ``` const Resources newShared = resources.shared() .filter([this, name, slaveId](const Resource& resource) { return !allocations[name].resources[slaveId].contains(resource); }); ``` which I found more readable. Similarly in add/remove/unallocated. - Jiang Yan Xu On Sept. 6, 2016, 3:02 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45961/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 3:02 p.m.) > > > Review request for mesos, Benjamin Mahler, Joris Van Remoortere, Michael > Park, and Jiang Yan Xu. > > > Bugs: MESOS-4431 > https://issues.apache.org/jira/browse/MESOS-4431 > > > Repository: mesos > > > Description > ------- > > o Each shared resource is accouted via its share count. This count is > updated based on the resource operations (such as add and subtract) > in various scenarios such as task launch and terminate at multiple > modules such as master, allocator, sorter, etc. > o Only allow DESTROY if there are no running or pending tasks using > the volume. However, if the volume is in a pending offer to one or > more frameworks, rescind that offer before processing the DESTROY. > o To allow multiple tasks to be launched in the same ACCEPT call > using the same shared resource, we update the allocator and > sorter with additional copies of shared resources to reflect the > true shared count of allocated shared resources. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > dd07ed221d2c1755d2478369641ffdc46ecc4471 > src/master/allocator/mesos/hierarchical.cpp > 9e5db2196c6a541dc1208ba8b9f13ef9a518bcc4 > src/master/allocator/sorter/drf/sorter.hpp > 09aa685f2bd7197385959d7d70d5411d0fd72f06 > src/master/allocator/sorter/drf/sorter.cpp > 1f2954c564eea5a3c649a5cc7181cb69329f9e35 > src/master/http.cpp 525ef6cd7545d25f3ac89a6325ace6e6d768262a > src/master/master.hpp c32c7e9d859ef73216354e2c03ecc07d0009b12f > src/master/master.cpp b2a19a645528e8fc1fd48f5ac9929d38c9a76b49 > src/master/validation.hpp 3205ee1e699d0fb7ca16ced96a07be3a07cf8956 > src/master/validation.cpp 15e2ecc2de99d6bed522f45f855ba686bf19c008 > > Diff: https://reviews.apache.org/r/45961/diff/ > > > Testing > ------- > > Tests successful. > > > Thanks, > > Anindya Sinha > >
