----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45961/ -----------------------------------------------------------
(Updated Aug. 31, 2016, 9:17 a.m.) Review request for mesos, Benjamin Mahler, Joris Van Remoortere, Michael Park, and Jiang Yan Xu. Changes ------- Addressed review comments and migration to updated updateAllocation() api Bugs: MESOS-4431 https://issues.apache.org/jira/browse/MESOS-4431 Repository: mesos Description ------- o Each shared resource is accouted via its share count. This count is updated based on the resource operations (such as add and subtract) in various scenarios such as task launch and terminate at multiple modules such as master, allocator, sorter, etc. o Only allow DESTROY if there are no running or pending tasks using the volume. However, if the volume is in a pending offer to one or more frameworks, rescind that offer before processing the DESTROY. o To allow multiple tasks to be launched in the same ACCEPT call using the same shared resource, we update the allocator and sorter with additional copies of shared resources to reflect the true shared count of allocated shared resources. Diffs (updated) ----- src/common/resources.cpp a5f5902d8f7f2757e3aee35619bff5cc3a52f29b src/common/resources_utils.cpp 8e881a09500b0966b577e514077460f724868a8d src/master/allocator/mesos/hierarchical.hpp dd07ed221d2c1755d2478369641ffdc46ecc4471 src/master/allocator/mesos/hierarchical.cpp 9e5db2196c6a541dc1208ba8b9f13ef9a518bcc4 src/master/allocator/sorter/drf/sorter.hpp 09aa685f2bd7197385959d7d70d5411d0fd72f06 src/master/allocator/sorter/drf/sorter.cpp 1f2954c564eea5a3c649a5cc7181cb69329f9e35 src/master/http.cpp 525ef6cd7545d25f3ac89a6325ace6e6d768262a src/master/master.hpp c32c7e9d859ef73216354e2c03ecc07d0009b12f src/master/master.cpp 192b2ce5eb24deb6e843f2f1a8c915114614b268 src/master/validation.hpp 3205ee1e699d0fb7ca16ced96a07be3a07cf8956 src/master/validation.cpp 15e2ecc2de99d6bed522f45f855ba686bf19c008 src/tests/master_validation_tests.cpp e440ff3f6d04f797e65874b9f610ed63d9f28e0e src/tests/sorter_tests.cpp 821e30d6574b045d25d4de4f7c3b8ac5346d3002 src/v1/resources.cpp 172217505d80d66cb7e10b3635dc273229313601 Diff: https://reviews.apache.org/r/45961/diff/ Testing ------- Tests successful. Thanks, Anindya Sinha