> On Sept. 8, 2016, 2:59 p.m., Vinod Kone wrote: > > src/cli/execute.cpp, lines 117-121 > > <https://reviews.apache.org/r/51623/diff/1/?file=1490738#file1490738line117> > > > > We want to add support for running multiple containers with different > > images, not just multiple commands! For example we want to be able to run > > docker images > > "redis" and "nginx" as a group. > > > > In other words each task could potentially have different values for > > name, shell, command, environment, resources, appc_image, docker_image, > > volumes. > > > > I propose as follows: > > > > ``` > > --taskgroup="{..JSON string}" > > ``` > > > > Parse this into `TaskGroupInfo` > > Abhishek Dasgupta wrote: > Ok, got it. But in this case do we need to keep old name, shell, command, > environment, resources, appc_image, docker_image, volumes options as well?? > And if we keep, then our logic should be if --taskgroup is present, ignore > all other name, shell, command, environment, resources, appc_image, > docker_image, volumes options. Just need to confirm this approach. > > Vinod Kone wrote: > yes, lets keep the other flags for backwards compatibility. and correct > if "taskgroup" is specified others shouldn't be. > > Avinash sridharan wrote: > Instead of taking a JSON string as an input to --taskgroup, can we take a > JSON file as an input? It will become a pain for users to give entire JSON > strings on the command line, given that taskgroups will be relatively verbose. > > Vinod Kone wrote: > sure. or we can allow both as we do in mesos.
+1 - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51623/#review148188 ----------------------------------------------------------- On Sept. 3, 2016, 8:36 p.m., Abhishek Dasgupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51623/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2016, 8:36 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Bugs: MESOS-6096 > https://issues.apache.org/jira/browse/MESOS-6096 > > > Repository: mesos > > > Description > ------- > > sThis patch updates mesos-execute to use LAUNCH_GROUP > for launching task groups. I made some assumption > in this patch, like newly introduced `--commands` > option in mesos-execute takes semicolon dimilited values > which will certainly not be the case in final solution. I > am open to suggestion what can we use as delimitter for > `--commands`. In this patch, I kept old `--command` option > as well and it is working as expected. Though new > `--commands` should be able to launch single as well > as multiple tasks and I hope in future we will stick > to one `commands` option. > > Suggestions are very welcome for further improvement. > > > Diffs > ----- > > src/cli/execute.cpp b752d057a3d86482ef1a4baaf31052469e38dc76 > > Diff: https://reviews.apache.org/r/51623/diff/ > > > Testing > ------- > > On Ubuntu 16.04: > sudo make -j4 > > and manually ran these commands: > **Successful** > mesos-execute --master=127.0.0.1:5050 --name="LetsCitar" > --containerizer=docker --docker_image="ubuntu" --command="echo hello" > > **Stuck after submitting task to agent as agent code for LAUNCH_GROUP is not > yet completed** > mesos-execute --master=127.0.0.1:5050 --name="LetsCitar" > --containerizer=docker --docker_image="ubuntu" --commands="echo hello" > > > Thanks, > > Abhishek Dasgupta > >
