-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51623/
-----------------------------------------------------------

(Updated Sept. 16, 2016, 6:58 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
-------

Updated with --taskgroup option in mesos-execute. In this revision most of the 
implementation is almost done. But the current implementation is not working 
for 'volumes' and 'environment' in following JSON format: 
[{
        "name": "sleep1",
        "command": "sleep 1000",
        "resources": "cpus:0.2;mem:32",
        "environment": [{
          "name1": "value1"
            },{
          "name2": "value2"
         }],
         "docker_image":"ubuntu",
         "volumes": [
           {
             "container_path":"/mnt/volume",
             "mode":"RW",
             "source":
               {
                 "docker_volume":
                   {
                     "driver": "rexray",
                     "docker_options":
                       {"parameter":[
                          {
                            "key": "key",
                            "value": "value"
                          }
                       ]},
                     "name": "volume_name"
                   },
                "type": "DOCKER_VOLUME"
              }
         }]
}, {
        "name": "sleep2",
        "command": "echo hello",
        "environment": [{
          "name1": "value1"
          }, {
           "name2": "value2"
         }],
         "docker_image":"ubuntu"
}]

Still need to work on that. It also have another flaw, if any garbage value is 
provided to 'docker_image', the task is still shown finished. However, this 
finished status come from the executor.


Bugs: MESOS-6096
    https://issues.apache.org/jira/browse/MESOS-6096


Repository: mesos


Description (updated)
-------

Updated mesos-execute to support task groups.


Diffs (updated)
-----

  src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 

Diff: https://reviews.apache.org/r/51623/diff/


Testing (updated)
-------

On Ubuntu 16.04:
sudo make -j4

and manually ran this command:
**Successful**
mesos-execute --master=127.0.0.1:5050 
--taskgroup=file:///home/abhishek/taskgroup.txt


Thanks,

Abhishek Dasgupta

Reply via email to