-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51623/#review149242
-----------------------------------------------------------



partial review.


src/cli/execute.cpp (line 116)
<https://reviews.apache.org/r/51623/#comment216801>

    s/tasks/`TaskGroup`/



src/cli/execute.cpp (line 117)
<https://reviews.apache.org/r/51623/#comment216802>

    s/tasks/TaskGroup/



src/cli/execute.cpp (line 119)
<https://reviews.apache.org/r/51623/#comment216816>

    Instead of hand-coded JSON, this should match the TaskGroup proto. See 
`volumes` below for how to do it.



src/cli/execute.cpp (line 278)
<https://reviews.apache.org/r/51623/#comment216820>

    this shoudld be Option<TaskGroup>



src/cli/execute.cpp (line 306)
<https://reviews.apache.org/r/51623/#comment216818>

    this should be optional.



src/cli/execute.cpp (line 308)
<https://reviews.apache.org/r/51623/#comment216819>

    this should be `Option<TaskGroup>`



src/cli/execute.cpp (line 310)
<https://reviews.apache.org/r/51623/#comment216817>

    this should be optional.



src/cli/execute.cpp (lines 1180 - 1190)
<https://reviews.apache.org/r/51623/#comment216815>

    Rather than ignoring, we should reject if both `--task-group` and other 
flags like `--name`, `--command` are set. Otherwise it's confusing.


- Vinod Kone


On Sept. 16, 2016, 6:58 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51623/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 6:58 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6096
>     https://issues.apache.org/jira/browse/MESOS-6096
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated mesos-execute to support task groups.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 
> 
> Diff: https://reviews.apache.org/r/51623/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> sudo make -j4
> 
> and manually ran this command:
> **Successful**
> mesos-execute --master=127.0.0.1:5050 
> --taskgroup=file:///home/abhishek/taskgroup.txt
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Reply via email to