> On Sept. 16, 2016, 7:42 p.m., Vinod Kone wrote:
> > src/cli/execute.cpp, line 119
> > <https://reviews.apache.org/r/51623/diff/2/?file=1500290#file1500290line119>
> >
> >     Instead of hand-coded JSON, this should match the TaskGroup proto. See 
> > `volumes` below for how to do it.

Didn't quite understand it. Are you suggesting me to create a `TaskGroup` 
proto? If it is so, our work will be very easy. No need to do those tedious 
parse.


- Abhishek


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51623/#review149242
-----------------------------------------------------------


On Sept. 16, 2016, 6:58 p.m., Abhishek Dasgupta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51623/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2016, 6:58 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-6096
>     https://issues.apache.org/jira/browse/MESOS-6096
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated mesos-execute to support task groups.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp c9f56af7f37d5b79b51f350d6c533714c170e889 
> 
> Diff: https://reviews.apache.org/r/51623/diff/
> 
> 
> Testing
> -------
> 
> On Ubuntu 16.04:
> sudo make -j4
> 
> and manually ran this command:
> **Successful**
> mesos-execute --master=127.0.0.1:5050 
> --taskgroup=file:///home/abhishek/taskgroup.txt
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>

Reply via email to