> On April 7, 2016, 6:25 p.m., haosdent huang wrote: > > 3rdparty/libprocess/src/subprocess.cpp, line 67 > > <https://reviews.apache.org/r/45491/diff/3/?file=1330257#file1330257line67> > > > > I think we could use `os::chdir` here? > > > > ``` > > inline Try<Nothing> chdir(const std::string& directory) > > { > > if (::chdir(directory.c_str()) < 0) { > > return ErrnoError(); > > } > > > > return Nothing(); > > } > > ```
I currently don't see any advantage here, as we are already in low level code, and I want to avoid as may dependencies as possible due to the async safe restriction on the child hooks. Is it ok to drop (otherwise please reopen)? - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/#review127636 ----------------------------------------------------------- On Sept. 21, 2016, 3:25 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45491/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2016, 3:25 p.m.) > > > Review request for mesos, Alexander Rukletsov and Jie Yu. > > > Bugs: MESOS-5070 > https://issues.apache.org/jira/browse/MESOS-5070 > > > Repository: mesos > > > Description > ------- > > Previously the subprocess interface supported a several options for the > child process such as setsid. In order to make the interface more > flexible we refactored such options into a vector of ChildHooks. > In order not to allow arbitrary code inside a ChildHook it has to be > constructed via pre-defined factory methods. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/posix/subprocess.hpp > 1e9a7b9051bb986dbda2a5ad408230a1bf6585f2 > 3rdparty/libprocess/include/process/ssl/gtest.hpp > 2ad623a5ea3b3286983e895010af756f14f51b64 > 3rdparty/libprocess/include/process/subprocess_base.hpp > 23bc14a30d013e47c4b48782a90523cd0bbb8c14 > 3rdparty/libprocess/src/subprocess.cpp > 8ca61f77083ac4b77aa1aec22806e1be43dbfa6c > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > 0ff3945d2c722ebc1529265427397c5dfba6854e > > Diff: https://reviews.apache.org/r/45491/diff/ > > > Testing > ------- > > Tested entire chain see https://reviews.apache.org/r/45492. > > > Thanks, > > Joerg Schad > >
