> On April 5, 2016, 6:40 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 219 > > <https://reviews.apache.org/r/45491/diff/2/?file=1320641#file1320641line219> > > > > Do we use this `operator() ()` style elsewhere? > > Joerg Schad wrote: > If you mean `operator()()` (vs `operator() ()`) then it is fixed. > Or were you refering to the pattern using `operator()()` in order to > expose private functions?
There are some (not to many occurences) of using operator()(). I would drop this for now (especially as it doesn't effect the way the hooks are specified, so can be changed with little effort). - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45491/#review127172 ----------------------------------------------------------- On Sept. 21, 2016, 3:25 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45491/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2016, 3:25 p.m.) > > > Review request for mesos, Alexander Rukletsov and Jie Yu. > > > Bugs: MESOS-5070 > https://issues.apache.org/jira/browse/MESOS-5070 > > > Repository: mesos > > > Description > ------- > > Previously the subprocess interface supported a several options for the > child process such as setsid. In order to make the interface more > flexible we refactored such options into a vector of ChildHooks. > In order not to allow arbitrary code inside a ChildHook it has to be > constructed via pre-defined factory methods. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/posix/subprocess.hpp > 1e9a7b9051bb986dbda2a5ad408230a1bf6585f2 > 3rdparty/libprocess/include/process/ssl/gtest.hpp > 2ad623a5ea3b3286983e895010af756f14f51b64 > 3rdparty/libprocess/include/process/subprocess_base.hpp > 23bc14a30d013e47c4b48782a90523cd0bbb8c14 > 3rdparty/libprocess/src/subprocess.cpp > 8ca61f77083ac4b77aa1aec22806e1be43dbfa6c > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > 0ff3945d2c722ebc1529265427397c5dfba6854e > > Diff: https://reviews.apache.org/r/45491/diff/ > > > Testing > ------- > > Tested entire chain see https://reviews.apache.org/r/45492. > > > Thanks, > > Joerg Schad > >
