> On Sept. 6, 2016, 6:54 p.m., Avinash sridharan wrote: > > src/health-check/health_checker.cpp, line 117 > > <https://reviews.apache.org/r/51607/diff/1/?file=1490612#file1490612line117> > > > > Shouldn't we check is this directory exists before creating this > > `HealthCheckerProcess`? > > Alexander Rukletsov wrote: > Probably not, we don't do it in `launchTaskPosix()`, moreover this flag > is required for executors.
After a second thought, this should be a check then. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51607/#review147887 ----------------------------------------------------------- On Oct. 4, 2016, 1:57 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51607/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 1:57 p.m.) > > > Review request for mesos, Avinash sridharan, Benjamin Mahler, Gastón Kleiman, > and haosdent huang. > > > Bugs: MESOS-6119 > https://issues.apache.org/jira/browse/MESOS-6119 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 > src/health-check/health_checker.hpp > 392b4d5bd1e5831994b9366c1eb5a2911e19860f > src/health-check/health_checker.cpp > ea93132f2a5d4828c75005f102eddc4c3131599d > src/launcher/executor.cpp 8a1051b886a0c95d19ff370e5c77d9c4033c8b61 > > Diff: https://reviews.apache.org/r/51607/diff/ > > > Testing > ------- > > make check on Mac OS 10.11.6 > > > Thanks, > > Alexander Rukletsov > >
