> On Sept. 9, 2016, 11:04 a.m., Gastón Kleiman wrote: > > src/health-check/health_checker.cpp, line 515 > > <https://reviews.apache.org/r/51607/diff/1/?file=1490612#file1490612line515> > > > > nit: I'd call this `tcpHealthCheckerPath`
If we update the binary name, yes : ). However, I still would like to keep its name generic. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51607/#review148325 ----------------------------------------------------------- On Sept. 2, 2016, 4:42 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51607/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2016, 4:42 p.m.) > > > Review request for mesos, Avinash sridharan, Benjamin Mahler, Gastón Kleiman, > and haosdent huang. > > > Bugs: MESOS-6119 > https://issues.apache.org/jira/browse/MESOS-6119 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/docker/executor.cpp f5981b080c0b81ef7025527ab26b36d7a01f009b > src/health-check/health_checker.hpp > 392b4d5bd1e5831994b9366c1eb5a2911e19860f > src/health-check/health_checker.cpp > f373df19fc8af8e9650be61e3b101e89362a67cd > src/launcher/executor.cpp 5370634ef9e6f3ac9717fed71f6a77707026a16a > > Diff: https://reviews.apache.org/r/51607/diff/ > > > Testing > ------- > > make check on Mac OS 10.11.6 > > > Thanks, > > Alexander Rukletsov > >
