> On 十月 9, 2016, 10:37 a.m., Guangya Liu wrote:
> > src/docker/docker.hpp, lines 125-136
> > <https://reviews.apache.org/r/50128/diff/10/?file=1507914#file1507914line125>
> >
> > 2 spaces
>
> Yubo Li wrote:
> where?
I mean it should be the following, keep 2 space at the start for the function
body.
```
friend std::ostream& operator<<(std::ostream& stream, const Device& device)
{
stream << device.hostPath.string() << ":";
stream << device.containerPath.string() << ":";
if (device.access.read) {
stream << "r";
}
if (device.access.write) {
stream << "w";
}
if (device.access.mknod) {
stream << "m";
}
return stream;
}
```
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50128/#review151937
-----------------------------------------------------------
On 九月 22, 2016, 6:20 a.m., Yubo Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50128/
> -----------------------------------------------------------
>
> (Updated 九月 22, 2016, 6:20 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull.
>
>
> Bugs: MESOS-5795
> https://issues.apache.org/jira/browse/MESOS-5795
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Wrapped helper functions 'serialize()' and 'parse()' to 'Docker::Device'
> to handle data tranformation between 'Docker::Device' structure and
> string.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0
> src/docker/docker.cpp 7c38123f1bedc7cda9c30ce9dd9877b7c41988fb
>
> Diff: https://reviews.apache.org/r/50128/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Yubo Li
>
>
