----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50128/#review151937 -----------------------------------------------------------
src/docker/docker.hpp (lines 95 - 120) <https://reviews.apache.org/r/50128/#comment220607> What about moving this to https://reviews.apache.org/r/50125/ where this will be used. src/docker/docker.hpp (lines 103 - 117) <https://reviews.apache.org/r/50128/#comment220608> You can call above `parse` directly here. src/docker/docker.hpp (lines 125 - 136) <https://reviews.apache.org/r/50128/#comment220606> 2 spaces - Guangya Liu On 九月 22, 2016, 6:20 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50128/ > ----------------------------------------------------------- > > (Updated 九月 22, 2016, 6:20 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Wrapped helper functions 'serialize()' and 'parse()' to 'Docker::Device' > to handle data tranformation between 'Docker::Device' structure and > string. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/docker.cpp 7c38123f1bedc7cda9c30ce9dd9877b7c41988fb > > Diff: https://reviews.apache.org/r/50128/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
